19.0 tutorials karad#1364
Open
karad-odoo wants to merge 17 commits into
Open
Conversation
- Create initial module directory with __manifest__.py and __init__.py files for the Odoo training tutorial.
- Add author and license attributes to __manifest__.py. - Fix code formatting issues across the module.
- Remove empty or unused default fields from __manifest__.py.
- Create 'estate.property' model definition inside models/estate_property.py. - Define core scalar fields for real estate advertisements.
- Clean up Python and XML files to adhere to Odoo PEP8 and XML linting standards.
- Add ir.model.access.csv under security directory. - Register security file in __manifest__.py data list. - Grant CRUD permissions on 'estate.property' to base.group_user.
- Define window action and 3-tier menu structure for estate module. - Set 'selling_price' field as read-only and disable copy attribute on price fields. - Set default business values for bedrooms and default availability lag. - Add 'active' and 'state' tracking fields to estate.property.
- Add .idea/ folder to .gitignore. - Remove cached PyCharm environment files from git tracking.
- Add list view for 'estate.property' containing key fields including title, postcode, living area, and pricing attributes.
- Rename list view fields 'title' to 'name' and 'available_from' to 'date_availability' to match Python model field definitions. - Fix ParseErrors encountered during module loading.
- Add basic form view architecture for 'estate.property'. - Organize view structure with title, property parameters group, and a description notebook.
- Add initial search view definition for 'estate.property'. - Include searchable fields: title, postcode, expected_price, bedrooms, living_area, and facades.
- Add predefined filter for available properties (state 'new' or 'offer_received'). - Add 'Postcode' group-by rule to the search view layout.
- Configure 'selling_price' field as read-only. - Prevent field duplication on copy for prices and availability dates. - Add default values for bedrooms and date_availability. - Add 'state' selection field and 'active' boolean for record lifecycle tracking.
- Increase module version in __manifest__.py to force Odoo database registry update.
- Reorder model fields to position 'state' before 'active' attribute. - Fix form view name definition from 'estate.property.list' to 'estate.property.form'. - Add missing 'state' field to both list and form views. - Remove redundant string attributes on search fields to inherit model labels. - Clean up syntax formatting, filter spacing, and group-by layout in search view..
bit-odoo
reviewed
Jul 21, 2026
bit-odoo
left a comment
There was a problem hiding this comment.
Hello @karad-odoo
Good Start!
Can you please improve all your commit titles and message as well?
And you have left many unneccary empty lines.
Also, improve the PR title and description.
Thanks
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
There was a problem hiding this comment.
Should be one empty line at the end of the file.
Comment on lines
+8
to
+10
| <menuitem id="estate_menu_root" name="Real Estate"/> | ||
| <menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/> | ||
| <menuitem id="estate_property_menu_action" name="Properties" parent="estate_first_level_menu" |
There was a problem hiding this comment.
You can create a separate file for the menu.
| <field name="name">estate.property.list</field> | ||
| <field name="model">estate.property</field> | ||
| <field name="arch" type="xml"> | ||
|
|
| <field name="date_availability" string="Available From"/> | ||
| <field name="state" string="State"/> | ||
| </list> | ||
|
|
| <field name="name">estate.property.form</field> | ||
| <field name="model">estate.property</field> | ||
| <field name="arch" type="xml"> | ||
|
|
| </group> | ||
| </page> | ||
| </notebook> | ||
|
|
|
|
||
| </sheet> | ||
| </form> | ||
|
|
| <field name="selling_price"/> | ||
| </group> | ||
| </group> | ||
|
|
| </field> | ||
| </record> | ||
|
|
||
| </odoo> No newline at end of file |
There was a problem hiding this comment.
Should be one empty line at the end of the file.
- Move menu items from estate_property_views.xml to views/estate_menus.xml to maintain view separation standards. - Update __manifest__.py data order to load menus after views. - Clean up whitespace and ensure files end with a trailing newline.
karad-odoo
force-pushed
the
19.0-tutorials-karad
branch
from
July 21, 2026 09:13
8208a5f to
f2a88fc
Compare
karad-odoo
marked this pull request as ready for review
July 21, 2026 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

[ADD] estate: property model, security rules, and UI views
Initial setup for the
estatetutorial module.estate.propertymodel with fields and defaultsir.model.access.csv)